fix(migrations): avoid applying the same replacements twice when cleaning up unused imports #59656
+70
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning up unused imports If a file ends up in multiple programs, the unused imports migration was counting it twice. This was fine since the string replacements were handling it correctly, but it was printing out incorrect data. These changes rework the migration to de-duplicate the replacements and produce the data from the de-duplicated results.
crisbeto
added
action: review
angular-robot
bot
added
the
area: migrations
devversion
approved these changes
Jan 22, 2025
| return `${start}/${length}`; | ||
| /** Gets an ID that can be used to look up a node based on its location. */ | ||
| private getNodeID(start: number, length: number): NodeID { | ||
| return `${start}/${length}` as NodeID; |
There was a problem hiding this comment.
Clever idea! useful for other "id generations" in the future too (assuming it's always the same file; not e.g. .d.ts suddenty)
crisbeto
added
action: merge
|
This PR was merged into the repository by commit d66881d. The changes were merged into the following branches: main, 19.1.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ning up unused imports (#59656) If a file ends up in multiple programs, the unused imports migration was counting it twice. This was fine since the string replacements were handling it correctly, but it was printing out incorrect data. These changes rework the migration to de-duplicate the replacements and produce the data from the de-duplicated results. PR Close #59656
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…ning up unused imports (angular#59656) If a file ends up in multiple programs, the unused imports migration was counting it twice. This was fine since the string replacements were handling it correctly, but it was printing out incorrect data. These changes rework the migration to de-duplicate the replacements and produce the data from the de-duplicated results. PR Close angular#59656
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file ends up in multiple programs, the unused imports migration was counting it twice. This was fine since the string replacements were handling it correctly, but it was printing out incorrect data.
These changes rework the migration to de-duplicate the replacements and produce the data from the de-duplicated results.