Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): add outputs migration to combined shorthand #58318

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Adds the @Output migration to the combined @angular/core:signals migration.

Adds the `@Output` migration to the combined `@angular/core:signals` migration.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 23, 2024
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update` migrations label Oct 23, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 23, 2024
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should mention the migration in some angular.dev migration doc too, as a follow-up

@crisbeto crisbeto removed the request for review from pkozlowski-opensource October 23, 2024 07:38
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 23, 2024
@pkozlowski-opensource
Copy link
Member

Thnx for doing this @crisbeto 🎉

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 42607bf.

The changes were merged into the following branches: main

JsantosDK pushed a commit to JsantosDK/angular that referenced this pull request Nov 11, 2024
…#58318)

Adds the `@Output` migration to the combined `@angular/core:signals` migration.

PR Close angular#58318
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update` migrations target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants