fix(core): take skip hydration flag into account while hydrating i18n blocks #57299
+135
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
… blocks This commit updates serialization and hydration i18n logic to take into account situations when i18n blocks are located within "skip hydration" blocks. Resolves angular#57105.
AndrewKushnir
force-pushed
the
i18n_skip_hydration
branch
from
44d21b9 to
d0a736e
Compare
thePunderWoman
added
action: merge
|
This PR was merged into the repository by commit 45212c7. The changes were merged into the following branches: main, 18.1.x, 18.2.x |
henry-alakazhang
pushed a commit
to freelancer/angular
that referenced
this pull request
Aug 30, 2024
… blocks (angular#57299) This commit updates serialization and hydration i18n logic to take into account situations when i18n blocks are located within "skip hydration" blocks. Resolves angular#57105. PR Close angular#57299
This was referenced Sep 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
and-oli
pushed a commit
to and-oli/angular
that referenced
this pull request
Sep 30, 2024
… blocks (angular#57299) This commit updates serialization and hydration i18n logic to take into account situations when i18n blocks are located within "skip hydration" blocks. Resolves angular#57105. PR Close angular#57299
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates serialization and hydration i18n logic to take into account situations when i18n blocks are located within "skip hydration" blocks.
Resolves #57105.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?