Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add async run method on ExperimentalPendingTasks #56546

Closed
wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Jun 21, 2024

This helper method is simply a convenience function that reduces some boilerplate with manually adding and removing a task around some asynchronous function.

@atscott atscott added target: minor This PR is targeted for the next minor release core: zoneless Issues related to running Angular without zone.js labels Jun 21, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Jun 21, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 21, 2024
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

This helper method is simply a convenience function that reduces some
boilerplate with manually adding and removing a task around some
asynchronous function.
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @atscott 👍

@pullapprove pullapprove bot requested a review from AndrewKushnir September 10, 2024 20:37
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Sep 12, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 3ebe6b4.

The changes were merged into the following branches: main

and-oli pushed a commit to and-oli/angular that referenced this pull request Sep 30, 2024
…ular#56546)

This helper method is simply a convenience function that reduces some
boilerplate with manually adding and removing a task around some
asynchronous function.

PR Close angular#56546
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: zoneless Issues related to running Angular without zone.js detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants