Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(animations): remove deprecated matchesElement from AnimationDriver #55479

Closed
wants to merge 1 commit into from
Closed

refactor(animations): remove deprecated matchesElement from AnimationDriver #55479

wants to merge 1 commit into from
+0 −28

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 23, 2024 •
edited

BREAKING CHANGE: Deprecated matchesElement method has been removed from AnimationDriver as it is unused.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 23, 2024
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 23, 2024
@alan-agius4
refactor(animations): remove deprecated matchesElement from `Animat…
e75a810 
…ionDriver`

BREAKING CHANGE: Deprecated `matchesElement` method has been removed from `AnimationDriver` as it is unused.
@alan-agius4 alan-agius4 force-pushed the animations-match-element-remove branch from d548b0b to e75a810 Compare April 23, 2024 11:43
@ngbot ngbot bot removed this from the v18 feature freeze candidates milestone Apr 23, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review April 23, 2024 11:45
thePunderWoman
thePunderWoman approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-animations, fw-testing, public-api

pkozlowski-opensource
pkozlowski-opensource approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 23, 2024
atscott
atscott approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alxhub
Copy link
Member

alxhub commented Apr 23, 2024

This PR was merged into the repository by commit bcce85a.

@alxhub alxhub closed this in bcce85a Apr 23, 2024
@alan-agius4 alan-agius4 deleted the animations-match-element-remove branch April 23, 2024 20:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alan-agius4 @alxhub @atscott @pkozlowski-opensource @thePunderWoman