-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): add optional rounded transform support in cloudinary image loader #55364
feat(common): add optional rounded transform support in cloudinary image loader #55364
Conversation
ac6c240
to
3ed3fc4
Compare
Could you add a corresponding unit test, thank you. |
Hi, The unit test has been added. |
b05faac
to
99b5785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devashishSarmah thanks for the improvement!
Hi @AndrewKushnir, The linting has failed due to the merge commits "Merge branch 'angular:main' into image-loader-cloudinary-add-rounded-transform". What can be done here? |
You while need to rebase your PR, drop the merge commits and squash everything into a single commit. We'd like this change to be a single commit. Thank you. |
…age loader Currently, the cloudinary image loader doesn't support rounded transform. Add a new prop called `rounded` to the existing `ImageLoaderConfig.loaderParams` test(common): add test case for cloudinary loader rounded option add test case for the rounded transform option of cloudinary loader
b1c57ab
to
a4a5a52
Compare
Hi @JeanMeche, I have merged all my commits into a single one. |
This PR was merged into the repository by commit 24c6373. The changes were merged into the following branches: main |
…age loader (angular#55364) Currently, the cloudinary image loader doesn't support rounded transform. Add a new prop called `rounded` to the existing `ImageLoaderConfig.loaderParams` test(common): add test case for cloudinary loader rounded option add test case for the rounded transform option of cloudinary loader PR Close angular#55364
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the cloudinary image loader doesn't support rounded transform
Issue Number: N/A
What is the new behavior?
Added a change which enables the users to add a prop called
rounded
to the existingImageLoaderConfig.loaderParams
prop.Does this PR introduce a breaking change?
Other information