Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add optional rounded transform support in cloudinary image loader #55364

Conversation

devashishSarmah
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Currently, the cloudinary image loader doesn't support rounded transform

Issue Number: N/A

What is the new behavior?

Added a change which enables the users to add a prop called rounded to the existing ImageLoaderConfig.loaderParams prop.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@pullapprove pullapprove bot requested a review from dylhunn April 16, 2024 15:27
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 16, 2024
@pkozlowski-opensource pkozlowski-opensource added the area: common Issues related to APIs in the @angular/common package label Apr 16, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 16, 2024
@devashishSarmah devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from ac6c240 to 3ed3fc4 Compare April 17, 2024 10:37
@JeanMeche
Copy link
Member

Could you add a corresponding unit test, thank you.

@pullapprove pullapprove bot requested a review from thePunderWoman October 9, 2024 19:21
@devashishSarmah
Copy link
Contributor Author

Hi, The unit test has been added.

@thePunderWoman thePunderWoman requested review from AndrewKushnir and removed request for dylhunn and thePunderWoman October 9, 2024 19:24
@devashishSarmah devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from b05faac to 99b5785 Compare October 9, 2024 19:28
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devashishSarmah thanks for the improvement!

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release action: presubmit The PR is in need of a google3 presubmit labels Oct 11, 2024
@AndrewKushnir
Copy link
Contributor

Presubmit.

@devashishSarmah
Copy link
Contributor Author

Hi @AndrewKushnir, The linting has failed due to the merge commits "Merge branch 'angular:main' into image-loader-cloudinary-add-rounded-transform". What can be done here?

@JeanMeche
Copy link
Member

You while need to rebase your PR, drop the merge commits and squash everything into a single commit. We'd like this change to be a single commit. Thank you.

…age loader

Currently, the cloudinary image loader doesn't support rounded transform.
Add a new prop called `rounded` to the existing `ImageLoaderConfig.loaderParams`

test(common): add test case for cloudinary loader rounded option

add test case for the rounded transform option of cloudinary loader
@devashishSarmah devashishSarmah force-pushed the image-loader-cloudinary-add-rounded-transform branch from b1c57ab to a4a5a52 Compare October 14, 2024 05:20
@angular-robot angular-robot bot requested a review from AndrewKushnir October 14, 2024 05:20
@devashishSarmah
Copy link
Contributor Author

devashishSarmah commented Oct 14, 2024

Hi @JeanMeche, I have merged all my commits into a single one.

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Oct 22, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 24c6373.

The changes were merged into the following branches: main

@devashishSarmah devashishSarmah deleted the image-loader-cloudinary-add-rounded-transform branch October 24, 2024 05:16
JsantosDK pushed a commit to JsantosDK/angular that referenced this pull request Nov 11, 2024
…age loader (angular#55364)

Currently, the cloudinary image loader doesn't support rounded transform.
Add a new prop called `rounded` to the existing `ImageLoaderConfig.loaderParams`

test(common): add test case for cloudinary loader rounded option

add test case for the rounded transform option of cloudinary loader

PR Close angular#55364
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants