fix(compiler): remove support for unassignable expressions in two-way bindings #55342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
angular-robot
bot
added
the
detected: breaking change
crisbeto
added
the
action: global presubmit
crisbeto
commented
Apr 15, 2024
| @Input() value: any; | ||
| @Output() valueChange = new EventEmitter<any>(); | ||
| } | ||
| describe('tsickle compatibility', () => { |
There was a problem hiding this comment.
This suite was accidentally nested under the two-way binding one.
… bindings Two-way bindings are meant to represent a property binding to an input and an event binding to an output, e.g. `[(ngModel)]="foo"` represents `[ngModel]="foo" (ngModelChange)="foo = $event"`. Previously due to a quirk in the template parser, we accidentally supported unassignable expressions in two-way bindings. In angular#54154 the quirk was fixed, but we kept support or some common expression because of internal usages. Now the internal usages have been cleaned up so the backwards-compatibility code can be deleted. Externally a migration was added in angular#54630 that will automatically fix any places that depended on the old behavior. BREAKING CHANGE: Angular only supports writable expressions inside of two-way bindings.
crisbeto
force-pushed
the
invalid-two-way-bindings
branch
from
e89cabf
to
e3085bf
Compare
crisbeto
commented
Apr 15, 2024
| * | ||
| * This option is only present to support an automated migration away from the invalid syntax. | ||
| */ | ||
| allowInvalidAssignmentEvents?: boolean; |
There was a problem hiding this comment.
It's a bit unfortunate that we need to keep this around a little while longer at the parser level, but it's not user-facing and the only place that enables it is the migration so once it is deleted, we can just drop it from here.
devversion
approved these changes
Apr 15, 2024
|
Passing TGP. Marking as blocked until the last set of cleanups have landed. |
crisbeto
added
state: blocked
action: merge
|
Internal failures have been cleaned up, this should be ready to go. |
|
This PR was merged into the repository by commit 4eb0165. |
iteriani
pushed a commit
to iteriani/angular
that referenced
this pull request
Apr 18, 2024
… bindings (angular#55342) Two-way bindings are meant to represent a property binding to an input and an event binding to an output, e.g. `[(ngModel)]="foo"` represents `[ngModel]="foo" (ngModelChange)="foo = $event"`. Previously due to a quirk in the template parser, we accidentally supported unassignable expressions in two-way bindings. In angular#54154 the quirk was fixed, but we kept support or some common expression because of internal usages. Now the internal usages have been cleaned up so the backwards-compatibility code can be deleted. Externally a migration was added in angular#54630 that will automatically fix any places that depended on the old behavior. BREAKING CHANGE: Angular only supports writable expressions inside of two-way bindings. PR Close angular#55342
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two-way bindings are meant to represent a property binding to an input and an event binding to an output, e.g.
[(ngModel)]="foo"represents[ngModel]="foo" (ngModelChange)="foo = $event". Previously due to a quirk in the template parser, we accidentally supported unassignable expressions in two-way bindings.In #54154 the quirk was fixed, but we kept support for some common expression because of internal usages. Now the internal usages have been cleaned up so the backwards-compatibility code can be deleted.
Externally a migration was added in #54630 that will automatically fix any places that depended on the old behavior.
BREAKING CHANGE:
Angular only supports writable expressions inside of two-way bindings.