Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Scroller should scroll as soon as change detection compl… #55105

Closed
wants to merge 1 commit into from
Closed

fix(router): Scroller should scroll as soon as change detection compl… #55105

wants to merge 1 commit into from

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Mar 28, 2024

…etes

Using setTimeout to delay scrolling can result in scrolling in the next frame and cause noticeable flicker. This commit scrolls as soon as the next render happens (or in setTimeout if a render does not happen before then).

fixes #53985

@atscott
fix(router): Scroller should scroll as soon as change detection compl…
4caa6ba 
…etes

Using `setTimeout` to delay scrolling can result in scrolling in the
next frame and cause noticeable flicker. This commit scrolls as soon as
the next render happens (or in `setTimeout` if a render does not happen
before then).

fixes angular#53985
@atscott atscott added area: router target: patch This PR is targeted for the next patch release labels Mar 28, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 28, 2024
@atscott atscott requested a review from alxhub April 1, 2024 17:03
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Apr 26, 2024
@atscott atscott removed the request for review from alxhub April 26, 2024 22:06
@AndrewKushnir AndrewKushnir added the action: global presubmit The PR is in need of a google3 global presubmit label Apr 29, 2024
@atscott
Copy link
Contributor Author

atscott commented Apr 30, 2024 •
edited

TESTED=https://fusion2.corp.google.com/presubmit/629147336/OCL:629147336:BASE:629272844:1714448285925:76b4fdef/targets

@atscott atscott added requires: TGP This PR requires a passing TGP before merging is allowed and removed action: global presubmit The PR is in need of a google3 global presubmit labels Apr 30, 2024
@pullapprove pullapprove bot removed requires: TGP This PR requires a passing TGP before merging is allowed labels Apr 30, 2024
@atscott atscott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 30, 2024
@atscott
Copy link
Contributor Author

atscott commented Apr 30, 2024

caretaker note: green TGP

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 66ffeca.

AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2024
@atscott @AndrewKushnir
fix(router): Scroller should scroll as soon as change detection compl…
aefee87 
…etes (#55105)

Using `setTimeout` to delay scrolling can result in scrolling in the
next frame and cause noticeable flicker. This commit scrolls as soon as
the next render happens (or in `setTimeout` if a render does not happen
before then).

fixes #53985

PR Close #55105
AndrewKushnir pushed a commit that referenced this pull request Apr 30, 2024
@atscott @AndrewKushnir
fix(router): Scroller should scroll as soon as change detection compl…
3eea50d 
…etes (#55105)

Using `setTimeout` to delay scrolling can result in scrolling in the
next frame and cause noticeable flicker. This commit scrolls as soon as
the next render happens (or in `setTimeout` if a render does not happen
before then).

fixes #53985

PR Close #55105
@pmoscode pmoscode mentioned this pull request May 22, 2024
Open
This was referenced May 22, 2024
Merged
Merged
@aminekun90 aminekun90 mentioned this pull request May 22, 2024
Open
@ambrose40 ambrose40 mentioned this pull request May 22, 2024
Open
This was referenced May 23, 2024
Merged
Merged
@WilsonSue WilsonSue mentioned this pull request May 24, 2024
Open
@merfu merfu mentioned this pull request May 25, 2024
Open
@JiM-99-dev JiM-99-dev mentioned this pull request May 25, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request May 26, 2024
Open
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: router merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Flickering during scroll restoration with scrollPositionRestoration: 'enabled' in Angular
2 participants
@atscott @AndrewKushnir