fix(core): return a readonly signal on asReadonly.
#54706
Closed
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
area: core
pkozlowski-opensource
approved these changes
Mar 5, 2024
pkozlowski-opensource
requested changes
Mar 5, 2024
JeanMeche
force-pushed
the
chore/model-readonly
branch
2 times, most recently
from
9d60335 to
3bf96fc
Compare
alxhub
approved these changes
Mar 5, 2024
pkozlowski-opensource
approved these changes
Mar 5, 2024
pkozlowski-opensource
added
the
action: merge
|
Shouldn't the commit message start with |
It actually should - great catch @jnizet - I will fix it while merging |
pkozlowski-opensource
added
merge: fix commit message
and removed
merge: fix commit message
labels
|
@JeanMeche it looks like this one will need a rebase - also, could you amend the commit message (as suggested by @jnizet ) while doing so? Thnx! |
pkozlowski-opensource
added
action: cleanup
JeanMeche
force-pushed
the
chore/model-readonly
branch
from
3bf96fc to
8ea531c
Compare
JeanMeche
force-pushed
the
chore/model-readonly
branch
3 times, most recently
from
a15e682 to
1c60adc
Compare
JeanMeche
added
action: merge
Previous `asReadonly()` returned the signal value and not the signal itself. Fixes angular#54704
JeanMeche
force-pushed
the
chore/model-readonly
branch
from
1c60adc to
fd2c620
Compare
JeanMeche
changed the title
asReadonly.asReadonly.
JeanMeche
added
target: minor
pkozlowski-opensource
approved these changes
Mar 6, 2024
|
This PR was merged into the repository by commit 7243c70. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous
asReadonly()returned the signal value and not the signal itself.Fixes #54704