fix(compiler-cli): do not throw fatal error if extended type check fails

[devversion]

Currently when the extended type check fails due to an import reference that cannot be generated, the fatal diagnostic is not caught and not properly exposed as a ts.Diagnostic that can be gracefully handled. This is inconsistent to non-extended type checking diagnostics.

This is problematic because Angular CLI applications currently fail in obscure ways because:

• the CLI does not expect getDiagnosticsForFile to actually throw runtime errors.
• the CLI does not seem to properly print these errors given the parallel workers and build excection, and those errors are especially hard to debug because there is no stack for FatalDiagnosticError's.

Example: MyDir is not exported and the type check block cannot reference it.

CLI currently will fail with errors like:

> ng serve

⠼ Building...
Application bundle generation failed. [3.335 seconds]
✘ [ERROR] Cannot read properties of null (reading 'errors') [plugin angular-compiler]

    node_modules/@angular-devkit/build-angular/src/tools/esbuild/angular/compiler-plugin.js:257:24:
      257 │         if (diagnostics.errors?.length) {
          ╵                         ^

    at /usr/local/google/home/pgschwendtner/projects/test-next/node_modules/@angular-devkit/build-angular/src/tools/esbuild/angular/compiler-plugin.js:257:25
    at async /usr/local/google/home/pgschwendtner/projects/test-next/node_modules/esbuild/lib/main.js:1350:22
    at async Promise.all (index 0)
    at async requestCallbacks.on-start (/usr/local/google/home/pgschwendtner/projects/test-next/node_modules/esbuild/lib/main.js:1348:5)
    at async handleRequest (/usr/local/google/home/pgschwendtner/projects/test-next/node_modules/esbuild/lib/main.js:732:11)

cc. @clydin

[dylhunn]

This PR was merged into the repository by commit 760b1f3.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}