Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): ignore empty switch blocks #53776

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 3, 2024

Adds some code to the compiler so that it ignores empty @switch blocks instead of trying to generate code for them.

Fixes #53773.

Adds some code to the compiler so that it ignores empty `@switch` blocks instead of trying to generate code for them.

Fixes angular#53773.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: compiler Issues related to `ngc`, Angular's template compiler labels Jan 3, 2024
@crisbeto crisbeto requested a review from atscott January 3, 2024 10:28
@ngbot ngbot bot added this to the Backlog milestone Jan 3, 2024
@crisbeto crisbeto removed the request for review from atscott January 3, 2024 11:15
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 3, 2024
@atscott
Copy link
Contributor

atscott commented Jan 3, 2024

This PR was merged into the repository by commit e5f0205.

@atscott atscott closed this in e5f0205 Jan 3, 2024
atscott pushed a commit that referenced this pull request Jan 3, 2024
Adds some code to the compiler so that it ignores empty `@switch` blocks instead of trying to generate code for them.

Fixes #53773.

PR Close #53776
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
Adds some code to the compiler so that it ignores empty `@switch` blocks instead of trying to generate code for them.

Fixes angular#53773.

PR Close angular#53776
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
Adds some code to the compiler so that it ignores empty `@switch` blocks instead of trying to generate code for them.

Fixes angular#53773.

PR Close angular#53776
danieljancar pushed a commit to danieljancar/angular that referenced this pull request Jan 26, 2024
Adds some code to the compiler so that it ignores empty `@switch` blocks instead of trying to generate code for them.

Fixes angular#53773.

PR Close angular#53776
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
Adds some code to the compiler so that it ignores empty `@switch` blocks instead of trying to generate code for them.

Fixes angular#53773.

PR Close angular#53776
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty @switch block can't compile
3 participants