fix(core): handle for alias with as in control flow migration #52183
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
requested review from
crisbeto and
jessicajaniuk
and removed request for
alxhub
pkozlowski-opensource
added
area: migrations
This adds the support of `let index as myIndex` in `*ngFor` for the control flow migration. Before: `@for (itm of items; track itm)` After: `@for (itm of items; track itm; let myIndex = $index)`
cexbrayat
force-pushed
the
fix/control-flow-migration-for-as
branch
from
7524df9 to
853ab64
Compare
jessicajaniuk
added
the
target: rc
jessicajaniuk
added
the
action: review
crisbeto
approved these changes
Oct 12, 2023
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit 37c8fd7. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Oct 12, 2023
This adds the support of `let index as myIndex` in `*ngFor` for the control flow migration. Before: `@for (itm of items; track itm)` After: `@for (itm of items; track itm; let myIndex = $index)` PR Close #52183
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…r#52183) This adds the support of `let index as myIndex` in `*ngFor` for the control flow migration. Before: `@for (itm of items; track itm)` After: `@for (itm of items; track itm; let myIndex = $index)` PR Close angular#52183
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This adds the support of
index as myIndexin*ngForfor the control flow migration.What is the new behavior?
Before:
@for (itm of items; track itm)After:
@for (itm of items; track itm; let myIndex = $index)Does this PR introduce a breaking change?
Other information