Correct escaping in various locations

[josephperrott]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• angular.io application / infrastructure changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[ngbot]

I see that you just added the action: merge label, but the following checks are still failing:
     status "mergeability" is failing
     forbidden labels detected: action: review
     status "pullapprove" is pending
     missing required status "ci/circleci: build"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[alfaproject]

Some of these look obviously broken or not expected and should be double-checked by the original author perhaps

If you see something like this: \s* then the author wanted it to be 0 or more whitespace characters, but now you changed it to s* which means 0 or more s characters.

So, if no tests fail and no one ever reported any issue, you can just remove the \s* altogether because it never did anything, or check with the author

[josephperrott]

@alfaproject I agree that this does not match what the author was intending to do in many of the cases, but these \ uses were superfluous. So the resulting regexs are actually the same.

These two strings create the same RegExp when actually interpretted:

new RegExp(`^test\s`) ==> /^tests/

new RegExp(`^tests`) ==> /^tests/

[jessicajaniuk]

This PR was merged into the repository by commit 1baeca8.

[alfaproject]

@josephperrott I know they do but that was not my point. Instead of fixing what the author intended or removing \s* altogether since it wasn't doing anything you left those regexes in a very weird format now....

[gultyayev]

Agree with @alfaproject. Looks like it would be better to do the \\ so that it would become the original intent of targeting a space instead of some literal "s"

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}