Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): show a more specific error for Ivy NgModules #41534

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): show a more specific error for Ivy NgModules #41534

wants to merge 1 commit into from

Commits on Apr 12, 2021

  1. fix(compiler-cli): show a more specific error for Ivy NgModules 

    When an Ivy NgModule is imported into a View Engine build, it doesn't have
metadata.json files that describe it as an NgModule, so it appears to VE
builds as a plain, undecorated class. The error message shown in this
situation generic and confusing, since it recommends adding an @NgModule
annotation to a class from a library.

This commit adds special detection into the View Engine compiler to give a
more specific error message when an Ivy NgModule is imported.
    @alxhub
    alxhub committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    87defbb View commit details
    Browse the repository at this point in the history