Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix possible XSS attack in development through SSR #40525

Closed
wants to merge 1 commit into from
Closed

fix(core): fix possible XSS attack in development through SSR #40525

wants to merge 1 commit into from

Commits on Jan 25, 2021

  1. fix(core): fix possible XSS attack in development through SSR 

    This is a follow up fix for
angular@894286d.

It turns out that comments can be closed in several ways:
- `<!-->`
- `<!-- -->`
- `<!-- --!>`

All of the above are valid ways to close comment per:
https://html.spec.whatwg.org/multipage/syntax.html#comments

The new fix surrounds `<` and `>` with zero width space so that it
renders in the same way, but it prevents the comment to be closed eagerly.
    @mhevery
    mhevery committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    cee860a View commit details
    Browse the repository at this point in the history