Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): do not recurse into modules that have already been registered #39514

Closed
wants to merge 2 commits into from
Closed

perf(core): do not recurse into modules that have already been registered #39514

wants to merge 2 commits into from

Commits on Oct 30, 2020

  1. perf(core): do not recurse into modules that have already been regist… 

    …ered

When registering an NgModule based on its id, all transitively imported
NgModules are also registered. This commit introduces a visited set to
avoid traversing into NgModules that are reachable from multiple import
paths multiple times.

Fixes angular#39487
    @JoostK
    JoostK committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    dfaf450 View commit details
    Browse the repository at this point in the history

  2. fixup! perf(core): do not recurse into modules that have already been… 

    … registered
    @JoostK
    JoostK committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    2b05235 View commit details
    Browse the repository at this point in the history