Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Ensure all outlets are used when commands has a prefix #39456

Closed
wants to merge 3 commits into from
Closed

fix(router): Ensure all outlets are used when commands has a prefix #39456

wants to merge 3 commits into from

Commits on Oct 29, 2020

  1. refactor(router): Small refactor of createUrlTree and extra tests 

    This commit has a small refactor of some methods in create_url_tree.ts
and adds some test cases, including two that will fail at the moment but
should pass. A follow-up commit will make use of the refactorings to fix
the test with minimal changes.
    @atscott
    atscott committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    acfce4a View commit details
    Browse the repository at this point in the history

  2. fix(router): Ensure all outlets are used when commands have a prefix 

    When there is a primary outlet present in the outlets map and the object is also prefixed
with some other commands, the current logic only uses the primary outlet and ignores
the others. This change ensures that all outlets are respected at the
segment level when prefixed with other commands.
    @atscott
    atscott committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c54f9e1 View commit details
    Browse the repository at this point in the history

  3. fixup! refactor(router): Small refactor of createUrlTree and extra tests

    @atscott
    atscott committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    5346092 View commit details
    Browse the repository at this point in the history