-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct escaping in various locations #51554
Conversation
Correct various Useless regular-expression character escape issues.
Correct various Useless regular-expression character escape issues.
Correct various Useless regular-expression character escape issues.
93ccc99
to
642f1f2
Compare
Correct various Useless regular-expression character escape issues.
642f1f2
to
9766305
Compare
Some of these look obviously broken or not expected and should be double-checked by the original author perhaps If you see something like this: So, if no tests fail and no one ever reported any issue, you can just remove the |
@alfaproject I agree that this does not match what the author was intending to do in many of the cases, but these These two strings create the same RegExp when actually interpretted: new RegExp(`^test\s`) ==> /^tests/
new RegExp(`^tests`) ==> /^tests/ |
This PR was merged into the repository by commit 1baeca8. |
Correct various Useless regular-expression character escape issues. PR Close #51554
Correct various Useless regular-expression character escape issues. PR Close #51554
Correct various Useless regular-expression character escape issues. PR Close #51554
@josephperrott I know they do but that was not my point. Instead of fixing what the author intended or removing |
Agree with @alfaproject. Looks like it would be better to do the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…51554) Correct various Useless regular-expression character escape issues. PR Close angular#51554
…gular#51554) Correct various Useless regular-expression character escape issues. PR Close angular#51554
…ngular#51554) Correct various Useless regular-expression character escape issues. PR Close angular#51554
…lar#51554) Correct various Useless regular-expression character escape issues. PR Close angular#51554
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information