Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate to nx 18 #1732

Merged
merged 4 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
echo "NX_CI_EXECUTION_ENV=Node $(node --version) -" >> $GITHUB_ENV

- name: Start Nx Cloud CI Run
run: npx nx-cloud start-ci-run --distributes-on="6 custom-linux-medium-plus-js" --stop-agents-after="e2e-suite"
run: npx nx-cloud start-ci-run --distributes-on="6 custom-linux-medium-plus-js"

- uses: actions/cache@v4
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
Expand Down
1 change: 1 addition & 0 deletions e2e/utils/start-and-publish-to-local-registry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default async () => {
env: process.env,
stdio: 'inherit',
maxBuffer: 1024 * 1024 * 10,
cwd: workspaceRoot,
});

execNx(['release', 'version', E2E_VERSION]);
Expand Down
1 change: 1 addition & 0 deletions jest.preset.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ module.exports = {
* https://github.com/jestjs/jest/issues/14305
*/
prettierPath: require.resolve('prettier-v2-for-jest-inline-snapshots'),
maxWorkers: 1,
};
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,17 @@
"@angular/compiler": "17.1.0",
"@commitlint/cli": "18.6.1",
"@commitlint/config-conventional": "18.6.3",
"@nx/devkit": "17.2.8",
"@nx/eslint-plugin": "17.2.8",
"@nx/jest": "17.2.8",
"@nx/js": "17.2.8",
"@nx/plugin": "17.2.8",
"@nx/workspace": "17.2.8",
"@nx/devkit": "18.0.8",
"@nx/eslint-plugin": "18.0.8",
"@nx/jest": "18.0.8",
"@nx/js": "18.0.8",
"@nx/plugin": "18.0.8",
"@nx/workspace": "18.0.8",
"@rollup/plugin-commonjs": "^25.0.0",
"@rollup/plugin-node-resolve": "^15.0.2",
"@rollup/plugin-typescript": "^11.1.0",
"@schematics/angular": "17.3.0",
"@swc-node/register": "1.6.8",
"@swc-node/register": "1.8.0",
"@swc/cli": "0.1.63",
"@swc/core": "1.3.104",
"@swc/helpers": "0.5.3",
Expand All @@ -90,7 +90,7 @@
"jsonc-eslint-parser": "^2.1.0",
"lint-staged": "15.2.0",
"ncp": "2.0.0",
"nx": "17.2.8",
"nx": "18.0.8",
"prettier": "3.1.1",
"prettier-v2-for-jest-inline-snapshots": "npm:prettier@^2",
"rimraf": "5.0.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/builder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"builders.json"
],
"dependencies": {
"@nx/devkit": "17.2.8",
"nx": "17.2.8"
"@nx/devkit": "^17.2.8 || ^18.0.0",
"nx": "^17.2.8 || ^18.0.0"
},
"builders": "./builders.json",
"peerDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/schematics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"dependencies": {
"@angular-eslint/eslint-plugin": "17.2.1",
"@angular-eslint/eslint-plugin-template": "17.2.1",
"@nx/devkit": "17.2.8",
"@nx/devkit": "^17.2.8 || ^18.0.0",
"ignore": "5.3.0",
"nx": "17.2.8",
"nx": "^17.2.8 || ^18.0.0",
"strip-json-comments": "3.1.1",
"tmp": "0.2.3"
},
Expand Down
1,458 changes: 850 additions & 608 deletions yarn.lock

Large diffs are not rendered by default.