Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output declaration files in all packages #1724

Merged
merged 1 commit into from Mar 15, 2024

Conversation

joeyj
Copy link
Contributor

@joeyj joeyj commented Feb 20, 2024

Resolves #1523

@joeyj joeyj changed the title Output *.d.ts files fix: Missing *.d.ts files in package Feb 20, 2024
Copy link

nx-cloud bot commented Mar 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 253df03. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry changed the title fix: Missing *.d.ts files in package fix: output declaration files in all packages Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.39%. Comparing base (c0d8a6e) to head (253df03).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
- Coverage   89.56%   89.39%   -0.18%     
==========================================
  Files         171      170       -1     
  Lines        3202     3196       -6     
  Branches      544      544              
==========================================
- Hits         2868     2857      -11     
- Misses        198      205       +7     
+ Partials      136      134       -2     
Flag Coverage Δ
unittest 89.39% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@JamesHenry JamesHenry merged commit c741307 into angular-eslint:main Mar 15, 2024
8 of 9 checks passed
@JamesHenry
Copy link
Member

Thanks @joeyj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type declaration files are missing from the distributed packages
2 participants