Allow shouldStartPlayback have the last rebuffer time #2113
+109
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colinkho
commented
Feb 7, 2025
•
colinkho
commented
- Add lastRebufferRealtimeMs to LoadControl.Parameters
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/LoadControl.java
Show resolved
Hide resolved
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/LoadControl.java
Show resolved
Hide resolved
libraries/exoplayer/src/test/java/androidx/media3/exoplayer/DefaultLoadControlTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @colinkho for your PR! I'm going to send this for internal review. Please ignore the comment around inline comments in the test class. I'm going to fix this myself and will push this to the PR once done. |
|
Hi, any update on the PR here? @marcbaechinger |
marcbaechinger
force-pushed
the
lastrebufferinssp
branch
from
b69f136 to
b4bff58
Compare
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
oceanjules
pushed a commit
that referenced
this pull request
Mar 3, 2025
PiperOrigin-RevId: 730919539 (cherry picked from commit 2c866ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.