New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip last statement when it only contains comment #669

Open

botenvouwer wants to merge 1 commit into andialbrecht:master from botenvouwer:proposal_to_fix_issue_668

botenvouwer commented Jun 3, 2022

It is also possible to add the last comment to the upper statement. However maybe this solution fits.

What is also possible is to add an option to leave comments out as a whole. Any way I hope you can use this.


          Strip last statement when it only contains comment

e980a61

Collaborator

mrmasterplan commented Jan 2, 2023

In my project I actively look at comments. This would not work for me. I need to know about statements even if they only contain comments.

IMO this is an issue easily (and best) solved by the library user.

The change you proposed needs more work. it needs to be configurable, it needs to be documented and it needs to have a unittest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment