fix: trim path from deps.json in portable way #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the path trimming regex would leave leading path separator in place on Windows. Probably a better long term fix is to a library path operation. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Signed-off-by: Will Murphy <will.murphy@anchore.com>
kzantow
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the path trimming regex would leave leading path separator in place on Windows.
Probably a better long term fix is to a library path operation.
Fixes #2264
TODO
use something more like filepath.Basename + removeSuffix(actually, we can't do this because the artifact being scanned might not use the same path separators as the host where syft is running).@wagoodman and I talked about this, and it doesn't seem like an underlying bug in the file abstraction, so I'm considering the investigation that was the last todo completed.