Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to path filtering #2668

Conversation

jpalermo
Copy link
Contributor

Fixes #2667

#2644 caused the skipping of any files or folders that included the prefix "/proc", "/dev" and "/sys" which was not the intended change and excludes many things that should be scanned.

This reverts commit a909e3c.

…nchore#2644)"

This change caused the skipping of any paths including "/proc", "/dev" and "/sys" which
was not the intended change and excludes many things that should be scanned.

anchore#2667

This reverts commit a909e3c.

Signed-off-by: Joseph Palermo <joseph.palermo@broadcom.com>
Copy link
Contributor

@manifestori manifestori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High priority, this change is breaking catalogers.
LGTM

@wagoodman
Copy link
Contributor

wagoodman commented Feb 28, 2024

I'm going to close this PR since I have another PR that is up for review that considers both the additional case that #2644 addresses and the original behavior: #2675

Thanks for bringing up this issue @jpalermo and providing a fix PR -- greatly appreciated!

@wagoodman wagoodman closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New path filtering logic excluding large number of unintended paths
3 participants