fix(install): return error codes from install script #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously exit was called with the stdout content of the main function. This did not make sense and resulted in the script not returning the expected exit codes when main returned a non-zero code. Strangely enough this broken code was introduced in response to anchore#1566 but I do not see how it ever worked unless the script used to echo its intended exit code. Signed-off-by: Stefan Hacker <mail@hacst.net>
kzantow
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thanks @hacst -- I can confirm this version works on sh in alpine:latest and macOS. For what it's worth: the version written as exit $(main "$@") did work properly on macOS, but not alpine, and this seems to be the right way to do it. 👍
hacst
added a commit
to hacst/grype
that referenced
this pull request
Feb 23, 2024
As the main function was not the last command, it did always return a zero status code. Exiting right after main allows us to return the actual return code instead. Analogous to anchore/syft#2664 . Signed-off-by: Stefan Hacker <mail@hacst.net>
kzantow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously exit was called with the stdout content of the main function. This did not make sense and
resulted in the script not returning the expected exit codes when main returned a non-zero code.
Strangely enough this broken code was introduced in response to #1566 but I do not see how it ever worked unless the script used to echo its intended exit code.