New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor source creation and add --from
flag
#2610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
4 tasks
wagoodman
reviewed
Feb 8, 2024
wagoodman
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the source/*
packages should be a little more consistent:
filesource
: good as isdirectory
->directorysource
stereoscope
->stereoscopesource
wagoodman
reviewed
Feb 8, 2024
wagoodman
reviewed
Feb 8, 2024
wagoodman
reviewed
Feb 8, 2024
wagoodman
reviewed
Feb 8, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
wagoodman
reviewed
Feb 26, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great refactor! 💯
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following high-level changes:
source.Detect
function has been removed, instead use:syft.GetSource
function, which has been added as the entrypoint to use syft defined sourcessource/filesource
source/directorysource
source/stereoscopesource
--from
flag is added, allowing the user to select the source(s) to usesource/sourceproviders
package has been added which defines the set of tagged providers Syft implements, available by calling the theAll
functionCloses #1783
TODO:
syft/source/detection_test.go
, as there isn't the same need to test the "detection" aspect, but there probably are still some valid test cases heretestutil.Chdir(t, "..")
acceptable? (at least as part of this PR to limit the changes)generateSBOMForAttestation
?