Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI package count does not match package count in default table output #2672

Closed
tk103331 opened this issue Feb 27, 2024 · 1 comment · Fixed by #2679
Closed

TUI package count does not match package count in default table output #2672

tk103331 opened this issue Feb 27, 2024 · 1 comment · Fixed by #2679
Assignees
Labels
bug Something isn't working

Comments

@tk103331
Copy link

What happened:

I scanned a project and found 859 packages, like the following:
image

But the table below shows that there are only about 630.
This is often confusing.
I found that the package is deduplicated before printing to the table.

rows = removeDuplicateRows(rows)

What you expected to happen:
Should there be an obvious hint?

Steps to reproduce the issue:

Anything else we need to know?:

Environment:

  • Output of syft version: master
  • OS (e.g: cat /etc/os-release or similar): mac
@tk103331 tk103331 added the bug Something isn't working label Feb 27, 2024
@wagoodman
Copy link
Contributor

There is a similar issue against grype, and the suggestion made there is to mark the rows where there are duplicates with the number of instances found. Why not go the other way around (report the de-duplicated number in the TUI output)? Because in other output formats, such as the JSON output, the de-duplicated count is what will be used.

Screenshot 2024-02-28 at 4 02 58 PM

How does an output similar to this sound?

@wagoodman wagoodman self-assigned this Feb 28, 2024
@wagoodman wagoodman changed the title Confusing number of packages TUI package count does not reflect count in default table output Feb 29, 2024
@wagoodman wagoodman changed the title TUI package count does not reflect count in default table output TUI package count does not match package count in default table output Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants