Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using image:tag for input results in invalid artifact names #396

Closed
coxauto-kennyg opened this issue Feb 24, 2023 · 4 comments
Closed

Using image:tag for input results in invalid artifact names #396

coxauto-kennyg opened this issue Feb 24, 2023 · 4 comments

Comments

@coxauto-kennyg
Copy link

Using image:tag for input results in invalid artifact names.

Error: Artifact name is not valid: `<redacted>-python:3.9.spdx.json`. Contains the following character:  Colon :
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.
@kzantow
Copy link
Contributor

kzantow commented Feb 24, 2023

This seems to be a limitation with GitHub workflow artifacts, I'm not sure it's something we can change/fix. Did you have any suggestions?

@coxauto-kennyg
Copy link
Author

I'd be satisfied with the default artifact name being used for images too.

@kzantow
Copy link
Contributor

kzantow commented Feb 24, 2023

Is there a workflow step definition you could provide that reproduces this? Are you specifying the artifact-name with the image:tag format? If so, just use a different artifact name.

If the action is generating the name, it replaces all the special characters from the image value, including : with underscore (_).

E.g. if I specify localbuild/testimage:latest, the artifact name is: localbuild-testimage_latest.spdx.json

@coxauto-kennyg
Copy link
Author

unfortunately, I'm unable to reproduce on public github. we have an artifactory acting as a proxy for docker hub as described here https://www.jfrog.com/confluence/display/JFROG/Docker+Registry. The image I was using registry.domain.com/python:3.9 breaks things. I can workaround it by specifying the artifact-name. thanks for looking into this.

lts-po pushed a commit to lts-po/sbom-action that referenced this issue May 3, 2023
Signed-off-by: lts-po <philip@supernetworks.org>
@kzantow kzantow closed this as completed in a59054d May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants