Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update breadcrumb tests #3944

Merged
merged 3 commits into from Mar 22, 2024
Merged

Update breadcrumb tests #3944

merged 3 commits into from Mar 22, 2024

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Mar 22, 2024

What

Minor update to contextual breadcrumb tests to better represent live behaviour

Why

To improve our confidence when we retire specialist topics in future work.

A page can be tagged to mainstream browse with or without a browse
parent. The breadcrumb is different in these two cases.
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3944 March 22, 2024 09:32 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3944 March 22, 2024 09:35 Inactive
@hannako hannako marked this pull request as ready for review March 22, 2024 09:35
Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@hannako hannako merged commit 582bc56 into main Mar 22, 2024
13 checks passed
@hannako hannako deleted the update_breadcrumb_tests branch March 22, 2024 09:45
hannako added a commit that referenced this pull request Mar 22, 2024
missed from #3944
@hannako hannako mentioned this pull request Mar 22, 2024
hannako added a commit that referenced this pull request Mar 22, 2024
missed from #3944
@andysellick andysellick mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants