Use component wrapper in document list component #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
document-list-component-wrapper
branch
from
f040713
to
62667c8
Compare
andysellick
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Nice. One small comment, but otherwise looks good.
Good job following up on this. Can you update https://docs.google.com/spreadsheets/d/1J-0IPyr2ycPuw1IWOIoX0o9Tk9nF35D0DJdsj_ylLQE/edit?pli=1#gid=1458513074 with this change? Thanks.
| component_helper.add_class("gem-c-document-list--no-top-border") if local_assigns[:remove_top_border] | ||
| component_helper.add_class("gem-c-document-list--no-top-border-first-child") if local_assigns[:remove_top_border_from_first_child] | ||
| margin_bottom = shared_helper.get_margin_bottom | ||
| component_helper.add_class(margin_bottom) if margin_bottom |
There was a problem hiding this comment.
I think this if margin_bottom check might be redundant because shared_helper.get_margin_bottom always returns a value, so I think these two lines could be written more simply as
component_helper.add_class(shared_helper.get_margin_bottom)
There was a problem hiding this comment.
@andysellick Thanks, will update and then merge 👍
AshGDS
force-pushed
the
document-list-component-wrapper
branch
from
62667c8
to
66a0c3e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Visual Changes
Document list yml examples will now have the uses component wrapper text