Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single cookie consent API #3854
Add single cookie consent API #3854
Changes from all commits
88c9f34
fe5418e
661980b
b34a892
d21cc1e
743b298
7b5f751
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention this. Here you're deleting the
essential
cookie but not reintroducing it into the cookie object when the user submits the form.Saving cookies isn't working properly in IE11 on this branch - it saves sucessfully, but then when I go to the homepage, the cookie settings I have in
document.cookie
are different to the ones that I saved.Could this be because
essential
is missing from the cookie when the form is saved, causing something odd?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a problem with this branch, or more generally? I don't think I introduced this change. Would it be alright to log this as an issue and for it to not block this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries - I've just tried it again and I think it's actually a weird IE11 caching thing. If I update my cookies, and go back to the homepage, the homepage gives me the old cookie state unless I add a cachebust query string to the URL. So don't worry about it