Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert nav menu font changes #3696

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Oct 31, 2023

What

Revert the nav menu font size and spacing to what was used before any of the recent design changes relating to the new homepage design.

The font-size changes were originally made as part of this PR - https://github.com/alphagov/govuk_publishing_components/pull/3666/files

Why

The changes were to be included as part of the new homepage design, however the height of the menu was too large and something that will be revisited in the future instead.

Visual Changes

New homepage design

Before After
new-homepage-nav-menu new-homepage-nav-menu-reverted

Current nav menu

It is worth noting that the current nav menu is also updated as part of this pull request, mainly the descriptions for the government activity sections of the page, the margin has changes, and also -webkit-font-rendering: antialiased is added back in.

Before After
current-nav-menu reverted-changes-nav-menu

However, I believe this is correct and was the original styling used in the main menu before recent changes were made as the screenshot below taken from Web Archive on 2nd August 2023 shows

wayback-machine-nav-menu https://web.archive.org/web/20230802235321/https://www.gov.uk/

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Revert the nav menu font size and spacing to what was used before any of the recent design changes relating to the new homepage design.
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3696 October 31, 2023 15:38 Inactive
@MartinJJones MartinJJones marked this pull request as ready for review October 31, 2023 15:55
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3696 October 31, 2023 15:56 Inactive
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MartinJJones 👍

@MartinJJones MartinJJones merged commit dbdc47e into main Oct 31, 2023
5 checks passed
@MartinJJones MartinJJones deleted the revert-nav-menu-font-changes branch October 31, 2023 16:14
@MartinJJones MartinJJones mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants