Use ActiveSupport::Logger instead of Ruby std Logger for the Rails apps #309
Conversation
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # 9.0.4 | |||
|
|
|||
| * Fix an issue of using Production like logs in development environment. | |||
There was a problem hiding this comment.
This doesn't really tell users much about the change or the issue. Would suggest something like: Fix Rails logger not being a descendent of ActiveSupport::Logger and thus lacking expected methods.
It'd also be good to follow the convention of linking to the PR that introduced the changelog (some are gems are very consistent with this but this one seems to have become a bit loose)
| @@ -26,6 +26,7 @@ def self.configure | |||
| "#{hash.to_json}\n" | |||
| }, | |||
| ) | |||
| Rails.logger = ActiveSupport::TaggedLogging.new(logger) | |||
There was a problem hiding this comment.
It's a bit of a surprise to me that we use ActiveSupport::TaggedLogging here since the commit only talks about ActiveSupport::Logger. I would be more expecting that the change was: Rails.logger = ActiveSupport::Logger.new(
Couple of things I wonder:
a) do we actually need the tagged logger? if so can we include the reasons for that in the commit, if not shall we simplify to just ActiveSupport::Logger?
b) if someone was to actually set a tag logger.tag("test") { logger.warn("hi") } might that actually break the JSON output or does it just prefix the message (hopefully the latter, just determining if tagging is dangerous)
There was a problem hiding this comment.
Yeah totally agree, we ended up using ActiveSupport::TaggedLoggging because ActiveSupport::Logger.new() didn't immediately work as expected. I had another playaround with it and realized that the formatter needs to be set separately instead of part of the keyword arguments in order for it to work. The new version uses ActiveSupport::Logger instead of TaggedLogging.
…plication logger Rails libraries expect the `Rails.logger` instance to inherit from ActiveSupport::Logger. The standard library logger for example does not implement methods like `silence` which is used by some of the Rails internals. This change fixes the inheritance issue. Co-authored-by: laura.ghiorghisor@digital.cabinet-office.gov.uk
tunylund
force-pushed
the
fix-logger-implementation
branch
from
ff2ac16
to
cc9fdbd
Compare
|
yeah tested the latest changes as well, all good 👍 |
Rails libraries expect the
Rails.loggerinstance to inherit from ActiveSupport::Logger. The ruby standard library logger for example does not implement methods likesilencewhich is used by some of the Rails internals.This change fixes the inheritance issue.
Co-authored-by: laura.ghiorghisor@digital.cabinet-office.gov.uk
This fixes the below error:
The error appears in development environment when Production like logging is enabled.
Tested with happy results:
