Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the types group with 1 update #4722

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 5, 2024

Bumps the types group with 1 update: @types/node.

Updates @types/node from 20.11.5 to 20.11.16

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Feb 5, 2024
@dependabot dependabot bot requested a review from a team February 5, 2024 10:36
Copy link

github-actions bot commented Feb 5, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 112.45 KiB
dist/govuk-frontend-development.min.js 38.58 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 78.74 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.99 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 112.44 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.57 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 70.32 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.57 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 4.46 KiB
components/notification-banner/notification-banner.mjs 4.93 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 4.39 KiB
components/tabs/tabs.mjs 10.16 KiB

View stats and visualisations on the review app


Action run for 74f7d26

@domoscargin
Copy link
Contributor

chokidar is incompatible with some changes in @types/node.

A fix has been merged, but unclear whether there'll be a new release (the last version of Chokidar is 2 years old at this point).

@querkmachine
Copy link
Member

A new release of chokidar has happened. Do we just need to wait for Dependabot to pick it up?

@colinrotherham
Copy link
Contributor

colinrotherham commented Feb 7, 2024

A new release of chokidar has happened. Do we just need to wait for Dependabot to pick it up?

@querkmachine We actually told Dependabot to ignore indirect updates like chokidar since 6bfbf66

Whilst lots of packages rely on chokidar, we don't actually install it directly ourselves 😣

├─┬ @govuk-frontend/lib@ -> ./shared/lib
│ └─┬ nunjucks@3.2.4
│   └── chokidar@3.5.3 deduped
├─┬ @govuk-frontend/review@ -> ./packages/govuk-frontend-review
│ ├─┬ browser-sync@3.0.2
│ │ └── chokidar@3.5.3 deduped
│ └─┬ nodemon@3.0.3
│   └── chokidar@3.5.3 deduped
├─┬ @govuk-frontend/webpack-boilerplate@ -> ./docs/examples/webpack
│ ├─┬ sass-loader@14.1.0
│ │ └─┬ sass@1.69.5
│ │   └── chokidar@3.5.3 deduped
│ └─┬ webpack-dev-server@4.15.1
│   └── chokidar@3.5.3 deduped
├─┬ @types/browser-sync@2.29.0
│ └── chokidar@3.5.3
├─┬ @types/gulp@4.0.17
│ └── chokidar@3.5.3 deduped
├─┬ govuk-frontend@5.1.0 -> ./packages/govuk-frontend
│ └─┬ govuk-prototype-kit@13.16.0
│   ├─┬ browser-sync@2.29.3
│   │ └── chokidar@3.5.3 deduped
│   └── chokidar@3.5.3 deduped
└─┬ gulp@4.0.2
  └─┬ glob-watcher@5.0.5
    └── chokidar@2.1.8 overridden

I'll ask Dependabot to recreate this PR (and others) and see what happens

But if none of our direct dependencies have picked up chokidar@3.6.0 we'll need a manual npm update PR

@dependabot recreate

Bumps the types group with 1 update: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node).


Updates `@types/node` from 20.11.5 to 20.11.16
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: types
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types-d1c9b9f358 branch from 828f998 to 74f7d26 Compare February 7, 2024 15:54
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4722 February 7, 2024 15:55 Inactive
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2024

Superseded by #4744.

@dependabot dependabot bot closed this Feb 9, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/types-d1c9b9f358 branch February 9, 2024 07:58
@colinrotherham
Copy link
Contributor

@domoscargin @querkmachine Kinda expected, but it didn't get picked up

Will checkout #4744 and npm update manually on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

None yet

4 participants