Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle query change when the text length does not change #621

Merged
merged 3 commits into from Jan 12, 2024
Merged

Handle query change when the text length does not change #621

merged 3 commits into from Jan 12, 2024

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Jan 12, 2024 •
edited

We have encountered a bug wherein a query text change that does not affect its length, does not trigger a search.
This PR aims to fix that by checking that the current and new query texts are not matching, rather than relying on the length check.

Originally raised by @archferns in #496

Rebases and re-builds dist as I didn't manage to push to the contributor's branch 馃様 .

@romaricpascal romaricpascal mentioned this pull request Jan 12, 2024
Closed
@romaricpascal romaricpascal added this to the Next milestone Jan 12, 2024
@romaricpascal romaricpascal merged commit 9010b0b into main Jan 12, 2024
3 checks passed
@romaricpascal romaricpascal deleted the rpa-handle-query-change branch January 12, 2024 16:30
This was referenced Mar 29, 2024
Merged
Merged
@romaricpascal romaricpascal mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

@archferns archferns archferns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romaricpascal @36degrees @archferns