Add menuAttributes to fix Axe's 'aria-input-field-name' error

[mchughbri]

Add the menuAttributes option to allow for attributes and their values to be added to the menu part of the component.

This fixes #361 as it allows for aria-labelledby to be set to the id of the existing label which in turn allows the code to pass the AXE rule "aria-input-field-name" (ARIA input fields have an accessible name).

No new tests have been added yet. While this PR adds the ability to add aria-label or aria-labelledby, by default these are not set, and so the default examples on the demo pages will still not pass the aXe tests.

What do you think we should do about this?

• Set a default aria-label value (But what would it say by default?)
• Forcibly set an id on the label and use aria-labelledby to associate the two
• Update all the examples to include manually setting an aria-label

[romaricpascal]

Thanks for this update @mchughbri (and your patience with us finding the time to review it 😬 ). The code update is looking good 🙌🏻

For the examples, it would be neat to update them now we have that new option. I think having an id and using aria-labelledby would nudge people towards the use intended for menuAttributes, so that would be my prefered way to go. If you have a moment to update them and add a little testing for the new option, that'd be ace! Thanks 😄

[mchughbri]

Thanks @romaricpascal

Now updated examples and added test for the new menuAttributes option

[romaricpascal]

@mchughbri Cheers for adding the tests and updating the examples, looks all neat to me! Seems our workflows have not started for some reason, though. Would you be able to run a quick force push on your branch to try and trigger them again, please? 😊

[mchughbri]

@romaricpascal now done thanks.

[romaricpascal]

Oh sorry for my unclear instructions, @mchughbri I meant a force push with a different commit hash to try and trigger whatever Github's do to relaunch the checks.

I usually git commit --amend -C HEAD which should generate a new hash for the last commit while keeping everything the same 😊

[mchughbri]

All done @romaricpascal thanks.

[romaricpascal]

Cheers! Tests are all green. Just needs a second approval and it'll be good to merge 😊

[mchughbri]

Hey @romaricpascal just wondered if we were any closer to getting another approval on this? Thanks.

[owenatgov]

@mchughbri Sorry for the second delay on this! Looking good, merged :)