Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed workdir of wrapped deployments #461

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented May 19, 2024

This commit fixes the inheritance mechanism for the workdir property of wrapped deployments. In the case where the wrapped deployment has not defined a workdir, but its wrapper deployment does, the first inherits from the second.

Moreover, the _inner_deploy method of the DefaultDeploymentManager class now injects the workdir into the DeploymentConfig of the inner connector. The previous behaviour did not lead to errors, but it was corrected to avoid future ones.

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (9a698de) to head (d961bc5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   70.14%   70.14%           
=======================================
  Files          83       83           
  Lines       10591    10591           
  Branches     2508     2508           
=======================================
  Hits         7429     7429           
+ Misses       2709     2703    -6     
- Partials      453      459    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey merged commit 8cdde0a into master May 20, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/workdir-wrap branch May 20, 2024 08:55
@GlassOfWhiskey GlassOfWhiskey changed the title Fixed workdir of wrapped deployment Fixed workdir of wrapped deployments May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants