Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NoContainerCWLDockerTranslator #453

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented May 13, 2024

This commit adds the possibility to execute a CWL step without using the containers even when it provides the DockerRequirement feature. In such case, the user must ensure that all the necessary applications are available on the bound execution locations.

@LanderOtto LanderOtto force-pushed the feat/no-container branch 4 times, most recently from 7ff366d to 9c30a82 Compare May 13, 2024 16:53
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.16%. Comparing base (3a65c35) to head (0464cd9).

Files Patch % Lines
streamflow/cwl/requirement/docker/nocontainer.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   70.13%   70.16%   +0.02%     
==========================================
  Files          83       84       +1     
  Lines       10587    10600      +13     
  Branches     2508     2509       +1     
==========================================
+ Hits         7425     7437      +12     
- Misses       2703     2705       +2     
+ Partials      459      458       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto force-pushed the feat/no-container branch 6 times, most recently from 9da5d31 to 0e1d1e9 Compare May 18, 2024 17:02
@GlassOfWhiskey GlassOfWhiskey merged commit fd24b5b into master May 30, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the feat/no-container branch May 30, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants