Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check job status when it terminates #452

Merged
merged 4 commits into from
May 31, 2024
Merged

Check job status when it terminates #452

merged 4 commits into from
May 31, 2024

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented May 10, 2024

This commit introduces a check of the job status inside the run method of the ExecuteStep class. It is helpful to terminate other running jobs of the same step, because if a job exits with an error status, the entire workflow run must fail. Such a failure does not depend on the manager, as the failure is handled inside the _run_job method itself.

Before this commit, the step was checking the job status only when all the jobs terminated their executions (either successfully or not). However, such a behavior results in a waste of time and computing resources.

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.12%. Comparing base (fd24b5b) to head (5f66221).

Files Patch % Lines
streamflow/workflow/step.py 74.07% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   70.15%   70.12%   -0.03%     
==========================================
  Files          84       84              
  Lines       10600    10611      +11     
  Branches     2509     2514       +5     
==========================================
+ Hits         7436     7441       +5     
- Misses       2705     2714       +9     
+ Partials      459      456       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

streamflow/workflow/step.py Outdated Show resolved Hide resolved
@LanderOtto LanderOtto force-pushed the feat/check-job branch 3 times, most recently from 367b29d to d754304 Compare May 18, 2024 23:54
@GlassOfWhiskey GlassOfWhiskey merged commit 6813bac into master May 31, 2024
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the feat/check-job branch May 31, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants