Check job status when it terminates #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a check of the job status inside the
run
method of theExecuteStep
class. It is helpful to terminate other running jobs of the same step, because if a job exits with an error status, the entire workflow run must fail. Such a failure does not depend on the manager, as the failure is handled inside the_run_job
method itself.Before this commit, the step was checking the job status only when all the jobs terminated their executions (either successfully or not). However, such a behavior results in a waste of time and computing resources.