-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed scheduling Policy
interface to take batch jobs in input
#418
base: master
Are you sure you want to change the base?
Conversation
…er. However, list is not hashable, so now it is frozen
streamflow/core/scheduling.py
Outdated
# for path, size in deployment_hw.storage.items(): | ||
# # todo: it is not really correct. They can have the same starts but be in different volumes | ||
# # e.g. / -> volume1 and /mnt/data -> volume2 | ||
# if job.tmp_directory.startswith(path): | ||
# size -= hw_requirement.tmp_dir_size | ||
# elif job.output_directory.startswith(path): | ||
# size -= hw_requirement.output_dir_size | ||
# storage[path] = size |
Check notice
Code scanning / CodeQL
Commented-out code Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 69.99% 70.32% +0.33%
==========================================
Files 83 83
Lines 10591 10601 +10
Branches 2505 2490 -15
==========================================
+ Hits 7413 7455 +42
+ Misses 2728 2700 -28
+ Partials 450 446 -4 ☔ View full report in Codecov by Sentry. |
d33094e
to
046d280
Compare
046d280
to
a6c78da
Compare
This commit changes the
Policy
interface to take in input batch of jobs. Prior this commit, it was passed one job at time. Instead, a global vision of all the pending jobs allows to implement more sophisticated scheduling strategies.This change involves the entire
Scheduler
class.