chore: improve interop between prettier and eslint #1212
Merged
+4
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme:mocha
epszaw
approved these changes
Jan 6, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // eslint-disable-next-line @stylistic/quotes | ||
| .replace('"', '"') | ||
| ); | ||
| return val.replace(/\n/g, "").replace(/\r/g, "").replace(/"/g, '\"'); |
Check warning
Code scanning / CodeQL
Replacement of a substring with itself
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, we need to change the replacement string from '\"' to '\\"'. This will ensure that double quotes are properly escaped by adding a backslash before them. The change should be made on line 464 of the file packages/newman-reporter-allure/src/index.ts.
Suggested changeset
1
packages/newman-reporter-allure/src/index.ts
| @@ -463,3 +463,3 @@ | ||
| #escape(val: string) { | ||
| return val.replace(/\n/g, "").replace(/\r/g, "").replace(/"/g, '\"'); | ||
| return val.replace(/\n/g, "").replace(/\r/g, "").replace(/"/g, '\\"'); | ||
| } |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
baev
force-pushed
the
prettier-eslint-interop
branch
from
9970f50 to
d49a524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
quotePropsto"consistent"to match ESLint'squote-propsrule.avoidEscapetotruefor ESLint's@stylistic/quotesrule to match Prettier's formatting behavior when dealing with strings with double quote characters inside (e.g.,'"foo"="bar"').ref allure-framework/allure3#29
Checklist