Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement flag overridenIsClean #738

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

balrok
Copy link
Contributor

@balrok balrok commented Apr 19, 2024

This flag is implemented similar to overriddenBranch and allows to set the "isClean" flag for the repository. Which basically determines if the working tree is dirty or clean.

One use-case is to speed up the computation when running the plugin locally as the isClean-calculation is quite time consuming. Also it may help during development of the version-rules.

This solves one part of issue #736

This flag is implemented similar to overriddenBranch and allows to set
the "isClean" flag for the repository. Which basically determines if the
working tree is dirty or clean.

One use-case is to speed up the computation when running the plugin
locally as the isClean-calculation is quite time consuming. Also it may
help during development of the version-rules.

This solves one part of issue allegro#736
@balrok balrok force-pushed the feature/overriddenIsClean-flag branch from 2ceff31 to 8af4f33 Compare April 19, 2024 20:36
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.96%. Comparing base (ed0a385) to head (8af4f33).
Report is 11 commits behind head on main.

Files Patch % Lines
...xion/release/infrastructure/git/GitRepository.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #738      +/-   ##
============================================
+ Coverage     61.00%   62.96%   +1.96%     
- Complexity      398      404       +6     
============================================
  Files            81       81              
  Lines          1554     1523      -31     
  Branches        147      147              
============================================
+ Hits            948      959      +11     
+ Misses          535      498      -37     
+ Partials         71       66       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgalek bgalek merged commit c7dcd21 into allegro:main Apr 21, 2024
3 checks passed
@bgalek
Copy link
Collaborator

bgalek commented Apr 21, 2024

LGTM, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants