Skip to content

Commit

Permalink
fix(deps): force a lower version of qs
Browse files Browse the repository at this point in the history
While this means it will be deduplicated less if people do use the later version of qs, it means a significant bundle size impact if we would have upgraded to 6.10+ (https://bundlephobia.com/package/qs@6.10.1 / ljharb/qs#404)
  • Loading branch information
Haroenv committed Jul 8, 2021
1 parent fc215a5 commit 765cbfa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -54,12 +54,13 @@
"dependencies": {
"@types/google.maps": "^3.45.3",
"@types/hogan.js": "^3.0.0",
"@types/qs": "^6.5.3",
"algoliasearch-helper": "^3.5.4",
"classnames": "^2.2.5",
"events": "^1.1.0",
"hogan.js": "^3.0.2",
"preact": "^10.0.0",
"qs": "^6.5.1"
"qs": "^6.5.1 < 6.10"
},
"devDependencies": {
"@algolia/client-search": "4.10.3",
Expand All @@ -81,7 +82,6 @@
"@types/enzyme": "^3.1.15",
"@types/jest": "^26.0.22",
"@types/jest-diff": "^24.3.0",
"@types/qs": "^6.5.3",
"@types/storybook__addon-actions": "^3.4.2",
"@typescript-eslint/eslint-plugin": "4.15.1",
"@typescript-eslint/parser": "4.15.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Expand Up @@ -11123,10 +11123,10 @@ qs@6.7.0:
resolved "https://registry.yarnpkg.com/qs/-/qs-6.7.0.tgz#41dc1a015e3d581f1621776be31afb2876a9b1bc"
integrity sha512-VCdBRNFTX1fyE7Nb6FYoURo/SPe62QCaAyzJvUjwRaIsc+NePBEniHlvxFmmX56+HZphIGtV0XeCirBtpDrTyQ==

qs@^6.5.1, qs@^6.6.0:
version "6.8.0"
resolved "https://registry.yarnpkg.com/qs/-/qs-6.8.0.tgz#87b763f0d37ca54200334cd57bb2ef8f68a1d081"
integrity sha512-tPSkj8y92PfZVbinY1n84i1Qdx75lZjMQYx9WZhnkofyxzw2r7Ho39G3/aEvSUdebxpnnM4LZJCtvE/Aq3+s9w==
qs@^6.6.0, "qs@^6.5.1 < 6.10":
version "6.9.6"
resolved "https://registry.yarnpkg.com/qs/-/qs-6.9.6.tgz#26ed3c8243a431b2924aca84cc90471f35d5a0ee"
integrity sha512-TIRk4aqYLNoJUbd+g2lEdz5kLWIuTMRagAXxl78Q0RiVjAOugHmeKNGdd3cwo/ktpf9aL9epCfFqWDEKysUlLQ==

qs@~6.5.2:
version "6.5.2"
Expand Down

0 comments on commit 765cbfa

Please sign in to comment.