Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): add logger-console package from v4 #3823

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2957

Changes included:

import the existing logger-console package, with minor tweaks to make it match our new v5 client.

the usage is similar and assert in the manual algoliasearch tests

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
@shortcuts shortcuts self-assigned this Sep 23, 2024
@shortcuts shortcuts requested a review from a team as a code owner September 23, 2024 13:22
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 23, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 250e8957583d2b9ef8ccfd1be4b9995ec20c17f0
🍃 Generated commit 28cae6d398c930d7c27337ce5205d645e538519b
🌲 Generated branch generated/feat/javascript-logger-package
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1665
go 1529
php 1405
csharp 1363
java 1101
python 1022
ruby 905
swift 736

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soooo nice, I can't find it but we had a very old jira ticket for this

@shortcuts
Copy link
Member Author

soooo nice, I can't find it but we had a very old jira ticket for this

yup I did not found it either

@shortcuts shortcuts merged commit db4cf48 into main Sep 23, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/javascript-logger-package branch September 23, 2024 16:10
algolia-bot added a commit that referenced this pull request Sep 23, 2024
…ed) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3823

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants