feat(javascript): add workerd exports #3680
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
| @@ -1,15 +1,21 @@ | |||
| import type { EchoResponse, EndRequest, Requester, Response } from './types'; | |||
|
|
|||
| type BasicURL = { | |||
There was a problem hiding this comment.
propose names if you want, it's mostly to avoid importing URL from anywhere
| initRecommend: (initOptions: InitClientOptions)=> RecommendClient; | ||
| initAnalytics: (initOptions: InitClientOptions & InitClientRegion<AnalyticsRegion>)=> AnalyticsClient; | ||
| initAbtesting: (initOptions: InitClientOptions & InitClientRegion<AbtestingRegion>)=> AbtestingClient; | ||
| initRecommend: (initOptions?: InitClientOptions)=> RecommendClient; |
There was a problem hiding this comment.
it forced us to pass an empty object, everything in here is partial
| algoliaAgents: [{ segment: 'Fetch' }], | ||
| requester: createFetchRequester(), |
There was a problem hiding this comment.
only two lines that differ from the node implem
| hostsCache: createMemoryCache(), | ||
| ...options, | ||
| }), | ||
| {{#nodeSearchHelpers}} |
There was a problem hiding this comment.
crypto is pollyfilled on cloudflare workers, so all good for now
for the worker export? I've defaulted it to esm |
|
I mean the "default" key you added to search-client etc, but I think it won't cause any issues |
|
I removed it in the end, it's never used when import and require is defined (thanks tsup for highlighting that D:) |
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#3680 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2890 https://algolia.atlassian.net/browse/DI-2895
Changes included:
closes algolia/algoliasearch-client-javascript#1548
this pr contains a few changes in few lines, sorry for the mess, but it's all related.
fetchbuildin order to improve our dx, we can provide a
fetchbuild output, as well as aworkerexports (which should also work for the cloudflare workers). this allows the user to directly load the client rather than having to manually setup fetch.manual testing
the manual testing is just a harness since the dependency clients are already tested, but in order to remove redundancy, common cases are moved to the
algoliasearch.common.test.tsfile.worker testing
cloudflare workers provide a miniflare instance for testing, pretty easy to setup, that at least allows us to ensure it's properly starting when loading the fetch client.