fix(javascript): prefix with node: for node packages
#3608
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks a lot for the contribution and the insight ❤️ |
shortcuts
changed the title
node: for node packagesnode: for node packages
algolia-bot
added a commit
that referenced
this pull request
Aug 28, 2024
…kip ci] Co-authored-by: Sébastien Chopin <seb@nuxtlabs.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Aug 28, 2024
algolia/api-clients-automation#3608 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Sébastien Chopin <seb@nuxtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
It is a best practice to prefix node packages with
node:Introduced in Node 18: https://stateful.com/blog/node-18-prefix-only-modules
This also ease support for edge-runtime like Cloudflare Workers (https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/)
Changes included:
cryptotonode:crypto