-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(javascript): add search wrappers to lite client #3556
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
would be interesting to see the bundle size on this one |
yup im adding the check |
still way lighter than v4, great: https://github.com/algolia/algoliasearch-client-javascript/blob/v4/package.json#L104-L107 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
…ed) [skip ci] Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#3556 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia/api-clients-automation#3556 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2746
Changes included:
Provide the search wrappers to the JavaScript
algoliasearch/lite
packagecloses algolia/algoliasearch-client-javascript#1536 (comment)