Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): add search wrappers to lite client #3556

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2746

Changes included:

Provide the search wrappers to the JavaScript algoliasearch/lite package

closes algolia/algoliasearch-client-javascript#1536 (comment)

@shortcuts shortcuts self-assigned this Aug 20, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 20, 2024 09:03
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 20, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 5ad7c98c5dd5bb76026988a106c8e248a863d701
🍃 Generated commit b8c5e7947cea358b5c44b0305ddc41508a98bea1
🌲 Generated branch generated/feat/javascript-lite-search-wrappers
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1388
php 1326
csharp 1114
java 937
ruby 866
swift 749
python 745
go 461
kotlin 431

@millotp
Copy link
Collaborator

millotp commented Aug 20, 2024

would be interesting to see the bundle size on this one

@shortcuts
Copy link
Member Author

would be interesting to see the bundle size on this one

yup im adding the check

@shortcuts
Copy link
Member Author

shortcuts commented Aug 20, 2024

Copy link

github-actions bot commented Aug 20, 2024

millotp
millotp previously approved these changes Aug 20, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@shortcuts shortcuts enabled auto-merge (squash) August 20, 2024 09:48
millotp
millotp previously approved these changes Aug 20, 2024
Fluf22
Fluf22 previously approved these changes Aug 20, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@shortcuts shortcuts dismissed stale reviews from Fluf22 and millotp via 7765118 August 20, 2024 10:31
@shortcuts shortcuts requested review from millotp and Fluf22 August 20, 2024 10:31
@shortcuts
Copy link
Member Author

sorry guys @Fluf22 @millotp

@shortcuts shortcuts merged commit c834388 into main Aug 20, 2024
21 checks passed
@shortcuts shortcuts deleted the feat/javascript-lite-search-wrappers branch August 20, 2024 11:44
algolia-bot added a commit that referenced this pull request Aug 20, 2024
…ed) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 20, 2024
algolia/api-clients-automation#3556

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
algolia/api-clients-automation#3556

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Typing Issue with response.results[0].hits in v5
4 participants