Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Update library and examples to Angular@12 #818

Merged
merged 11 commits into from
Jul 12, 2021
Merged

Update library and examples to Angular@12 #818

merged 11 commits into from
Jul 12, 2021
+29,324 −23,001

Conversation

tkrugg
Copy link
Contributor

@tkrugg tkrugg commented Jun 21, 2021 •
edited
Loading

Summary

  • updated library to allow @12

  • updated examples/e-commerce to @12 via ng update

  • updated examples/media to @10 via ng update (should probably update this one to @11 so we can say we support the last two LTS)

  • recreated examples/server-side-rendering on @12

  • updated storybook to use Angular @12 (in progress)

  • update API reference to Angular v4 (not started)

  • rewrite SSR documentation. (in progress https://github.com/algolia/doc/pull/5893)

Sorry, something went wrong.

tkrugg added 3 commits June 20, 2021 22:08
@tkrugg
feat: enable support for @12

Verified

This commit was signed with the committer’s verified signature.
achang97
GPG key ID: AD9D4E7B2B89F3D3
Verified
Learn about vigilant mode
26328de
@tkrugg
chore: update example e-commerce to @12

Verified

This commit was signed with the committer’s verified signature.
achang97
GPG key ID: AD9D4E7B2B89F3D3
Verified
Learn about vigilant mode
c193f30
@tkrugg
chore: update example media to @10

Verified

This commit was signed with the committer’s verified signature.
achang97
GPG key ID: AD9D4E7B2B89F3D3
Verified
Learn about vigilant mode
33790f3
@Haroenv
Copy link
Contributor

Haroenv commented Jun 21, 2021 •
edited
Loading

The node version on netlify needs to be fixed here:

9:04:36 AM: error @angular/common@12.0.3: The engine "node" is incompatible with this module. Expected version "^12.14.1 || >=14.0.0".
9:04:36 AM: error Found incompatible module

it uses v10 at the moment

@netlify
Copy link

netlify bot commented Jun 23, 2021 •
edited
Loading

✔️ Deploy Preview for angular-instantsearch ready!

🔨 Explore the source changes: cd36d80

🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-instantsearch/deploys/60e59a7f59303900070f72a3

😎 Browse the preview: https://deploy-preview-818--angular-instantsearch.netlify.app

@tkrugg tkrugg force-pushed the update-to-@11__reworked branch 2 times, most recently from 4c5e09d to 77bf2cb Compare July 5, 2021 10:31
@tkrugg tkrugg force-pushed the update-to-@11__reworked branch from 77bf2cb to 6948cb4 Compare July 5, 2021 11:04
@tkrugg tkrugg requested review from Haroenv and eunjae-lee July 5, 2021 11:05
Haroenv
Haroenv reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR!

examples/server-side-rendering/src/app/ssrRouter.ts
@@ -1,3 +1,4 @@
// @ts-nocheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what errors need to be suppressed?

@tkrugg tkrugg force-pushed the update-to-@11__reworked branch from 040e698 to 2e494d6 Compare July 6, 2021 12:33
@shortcuts shortcuts mentioned this pull request Jul 6, 2021
Closed
Haroenv
Haroenv approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's start with this

eunjae-lee
eunjae-lee approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the examples, but I think this PR looks good overall. Let's go with this version and figure out if any bug is found. (We're going to release as beta first, right?)

@tkrugg tkrugg mentioned this pull request Jul 9, 2021
Closed
@tkrugg tkrugg merged commit 33d9350 into v4 Jul 12, 2021
@tkrugg
Copy link
Contributor Author

tkrugg commented Jul 12, 2021

I haven't reviewed the examples, but I think this PR looks good overall. Let's go with this version and figure out if any bug is found. (We're going to release as beta first, right?)

Yes, also because the types in ISv4 aren't at their latest iteration

@tkrugg tkrugg deleted the update-to-@11__reworked branch July 12, 2021 09:19
@tkrugg tkrugg mentioned this pull request Jul 13, 2021
Merged
@ramikhafagi96
Copy link

please how to install this new version using npm?

@Haroenv Haroenv mentioned this pull request Jul 20, 2021
Merged
@danielehrhardt
Copy link

danielehrhardt commented Aug 19, 2021 •
edited
Loading

please how to install this new version using npm?

npm i https://github.com/algolia/angular-instantsearch.git#4.0.0-alpha.2
or
npm i angular-instantsearch@4.0.0-alpha.2

Is there any Documentation?

@Haroenv
Copy link
Contributor

Haroenv commented Aug 20, 2021

Yes, it's npm i angular-instantsearch@4.0.0-alpha.2

@tkrugg
Copy link
Contributor Author

tkrugg commented Aug 20, 2021

No documentation yet but it's coming in the next couple of weeks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eunjae-lee eunjae-lee

@Haroenv Haroenv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tkrugg @Haroenv @ramikhafagi96 @danielehrhardt @eunjae-lee