feat: replace all objects with loaded objects from a Sequence #400
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kengo TODA <skypencil@gmail.com>
KengoTODA
commented
Jul 11, 2023
|
|
||
| return mutableListOf<TaskIndex>().also { list -> | ||
| list += TaskIndex(indexName, indexSource.copyIndex(indexDestination.indexName, scopes).taskID) | ||
| batchOperations.chunked(10_000).forEach { |
There was a problem hiding this comment.
It would be difficult to find the "best number" that suits every case in the world.
At least in our case 10_000 works fine, but please tell me if we can improve this implementation (e.g. making it configurable?).
Signed-off-by: Kengo TODA <skypencil@gmail.com>
KengoTODA
changed the title
|
Hello @aallam, could you review this PR when you have time? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for keeping this client maintained and open! 🙌
I'm using this client to search and maintain data, and here is a PR that suggests providing more support to lazy programmers:
Describe your change
Support not only the
Listinterface but also theSequenceinterface when replacing all objects in an index.What problem is this fixing?
Currently the
replaceAllObjects()supports theListinterface only, which means that callers need to load all data onto the Java heap even though it could be huge.By supporting the
Sequenceinterface, callers can generate data lazily and reduce the memory footprint of their code.