caplog: Handle disabled logging in 'set_level' and 'at_level' #8711 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlambson
changed the title
alexlambson
force-pushed
the
issue-8711-handle-disabled-logging
branch
2 times, most recently
from
377d826
to
e52ee7c
Compare
…ytest-dev#8711 Forces requested `caplog` logging levels to be enabled if they were disabled via `logging.disable()` `[attr-defined]` mypy error ignored in `logging.py` because there were existing errors with the imports and `loggin.Logger.manager` is an attr set at runtime. Since it's in the standard lib I can't really fix that. Ignored an attr-defined error in `src/_pytest/config/__init__.py` because the re-export is necessary. Issue: pytest-dev#8711
- Resolves issues from review provided by https://github.com/andrewdotn - Fixed spelling errors - Improved logic in `force_enable_logging` - Make a fixture to un-disable logging after a test so that logging will be un-disabled even if the test fails due to an assertion error. The fixture is in `test_fixture.py` because we can't `import logging` in `conftest.py` because there is a module called `logging` in the same folder. - Mypy implicit import error. I can't commit without this. Issue: pytest-dev#8711 PR: pytest-dev#8758
- Adds test coverage for `force_enable_logging` with a string `level`. Fixes [code coverage check](https://github.com/pytest-dev/pytest/pull/8758/checks?check_run_id=4123920877) Issue: pytest-dev#8711 PR: pytest-dev#8758
- Address review ad rebase to latest from main - Make `force_enable_logging` private. Issue: pytest-dev#8711 PR: pytest-dev#8758
alexlambson
force-pushed
the
issue-8711-handle-disabled-logging
branch
from
e52ee7c
to
7f89996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces requested
caploglogging levels to be enabled if they were disabled vialogging.disable()[attr-defined]mypy error ignored inlogging.pybecause there were existing errors with the importsand
loggin.Logger.manageris an attr set at runtime. Since it's in the standard lib I can't really fix that.Ignored an attr-defined error in
src/_pytest/config/__init__.pybecause the re-export is necessary.Closes pytest-dev#8711